Skip to content

Update the F# Guide page and some ms.date links - #4521

Merged
cartermp merged 14 commits into
dotnet:masterfrom
cartermp:fs-tutorial-rework
Mar 14, 2018
Merged

cartermp merged 14 commits into
dotnet:masterfrom
cartermp:fs-tutorial-rework

Conversation

@cartermp

Copy link
Copy Markdown
Contributor

Centered around a better getting started experience for F#. This is based on looking at how other languages document content for newcomers and other learnings in this space. There will be more PRs to address further content.

@cartermp cartermp changed the title Fs tutorial rework Update the F# Guide page and some ms.date links Feb 28, 2018
Comment thread docs/fsharp/index.md Outdated

The [F# Snippets Website](http://www.fssnip.net) contains a massive set of code snippets showing how to do just about anything in F#, ranging from absolute beginner to highly advanced snippets.

The [F# Software Foundation Slack]()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

author: cartermp
ms.author: phcart
ms.date: 09/28/2016
ms.date: 02/28/2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on this topic suggest that the article should be updated to 4.1 and that you don't need Mono on Mac. Make sure that the article is still accurate before changing the date.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: 4.1 - I'm actually just going to remove that section. It's confusing, and the standalone install of F# atop Windows is something very few people do.

Re: Mono - still untrue, unfortunately. The .NET Core-only Ionide experience is still experimental.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good @cartermp!

@@ -1,18 +1,18 @@
---
title: Getting Started with F# in Visual Studio Code with Ionide
title: Getting Started with F# in Visual Studio Code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Get started without ing as well?

Comment thread docs/fsharp/index.md Outdated
description: Learn about F#, a functional programming language that runs on .NET.
keywords: .NET, .NET Core
description: Learn F#, a functional programming language that runs on .NET.
keywords: F#, .NET, .NET Core

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this line. We've learned over time it doesn't help with SEO.

Comment thread docs/fsharp/index.md Outdated
```

Additionally, the [F# Core Library Reference](https://msdn.microsoft.com/visualfsharpdocs/conceptual/fsharp-core-library-reference) is a great resource for learning about FSharp.Core, the core library which is a part of F#.
F# is about productivity at its heart. The tooling support for F# is ubiquitous and full of advanced features. See below to learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you working on VS Code? If so, can you install and use this extension:
https://review.docs.microsoft.com/en-us/help/contribute/contribute-get-started-setup-acrolinx-vscode?branch=master

It will capture some of the common style guide rules like don't use below.

Comment thread docs/fsharp/index.md Outdated

[Get Started with F# in Visual Studio Code](get-started/get-started-vscode.md) if you want a lightweight and feature-packed IDE experience.

[Get started with F# with the .NET Core CLI](get-started/get-started-command-line.md) if you just want a great set of command line tools.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

command line -> command-line

Comment thread docs/fsharp/index.md Outdated
* [Functions as First-Class Values](introduction-to-functional-programming/functions-as-first-class-values.md)<!--[Introduction to Functional Programming](introduction-to-functional-programming/index.md)-->
* [Language Reference](language-reference/index.md)
* [F# Core Library Reference](https://msdn.microsoft.com/visualfsharpdocs/conceptual/fsharp-core-library-reference)
[F# Programming Wikibook](https://en.wikibooks.org/wiki/F_Sharp_Programming) is a wonderful wikibook on learning F#. It is also a product of the F# community.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid adjectives like wonderful to describe things.

@BillWagner

Copy link
Copy Markdown
Member

@cartermp This branch has merge conflicts. Do you want to rebase and then I'll review?

@cartermp

cartermp commented Mar 1, 2018

Copy link
Copy Markdown
Contributor Author

@BillWagner done!

@mairaw

mairaw commented Mar 1, 2018

Copy link
Copy Markdown
Contributor

I'll take a look but build report is showing a broken link already:
image

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall. Highlighted a couple of suggestions from Acrolinx too.

```

Ionide automatically detects the compiler and tools, but if it doesn't for some reason (for example, the Visual F# Tools were installed to a different directory), you can manually add the containing folder (`...\Microsoft SDKs\F#\4.0`) to your PATH.
If you're on Windows, you must [install Visual Studio with F# support](get-started-visual-studio.md#installing-f). This will install all the necessary components to write, compile, and execute F# code.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs might come handy in these subsections:
https://review.docs.microsoft.com/en-us/new-hope/resources/tabbed-conceptual?branch=master&tabs=linux%2Cazure-cli#os

Do you need to add more details here? People might be surprised that in order for them to Get started with F# on VS Code, they also need to install the full VS as well.

will install -> installs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added/addressed

F# 4.0 or higher must be installed on your machine to use Ionide.

You must also have [git installed](https://git-scm.com/download) and available on your PATH to make use of project templates in Ionide. You can verify that it is installed correctly by typing `git` at a command prompt.and pressing **Enter**.
You must have [git installed](https://git-scm.com/download) and available on your PATH to make use of project templates in Ionide. You can verify that it is installed correctly by typing `git` at a command prompt and pressing **Enter**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be missing a couple of prereqs like Visual Studio Code and the Ionide plug-in.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned right below. These are prerequisities to actually get F# on your machine in a way that Ionide can use it.

# Getting Started with F# in Visual Studio Code with Ionide
# Get Started with F# in Visual Studio Code

You can write F# in [Visual Studio Code](https://code.visualstudio.com) with the [Ionide plugin](https://marketplace.visualstudio.com/items?itemName=Ionide.Ionide-fsharp), to get a great cross-platform, lightweight IDE experience with IntelliSense and basic code refactorings. Visit [Ionide.io](https://ionide.io) to learn more about the plugin suite.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to your changes but remove the extra space before Visit

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, my next action after this PR is to update this article, so I'll take care of the space-y problems then.

Comment thread docs/fsharp/index.md Outdated
title: F# Guide
description: Learn about F#, a functional programming language that runs on .NET.
keywords: .NET, .NET Core
description: Learn F#, a functional programming language that runs on .NET.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to expand this a bit more. The length should be between 115 and 145 characters. Maybe tell folks what they'll find in the Guide?

Comment thread docs/fsharp/index.md Outdated
[F# Programming Wikibook](https://en.wikibooks.org/wiki/F_Sharp_Programming) is a wikibook about learning F#. It is also a product of the F# community.

## Online Reading Resources
## Learn F# by video

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reads a bit funny like that. Learn through videos or with videos perhaps?

Comment thread docs/fsharp/index.md Outdated
## Learning F# #

Although Microsoft is the primary developer of the F# language and its tooling, F# is also backed by an independent foundation, the F# Software Foundation (FSSF).
[Tour of F#](tour.md) gives an overview of major language features with lots of code samples. Go here if you're interested in getting an overview of the language.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acrolinx result: Go here -> do not use

Comment thread docs/fsharp/index.md Outdated
[F# tutorial on YouTube](https://www.youtube.com/watch?v=c7eNDJN758U) is a great introduction to F# using Visual Studio, showing lots of great examples over the course of 1.5 hours.

## Video Learning Resources
[Introduction to Programming with F#](https://www.youtube.com/watch?v=Teak30_pXHk&list=PLEoMzSkcN8oNiJ67Hd7oRGgD1d4YBxYGC) is a great video series which uses Visual Studio Code as the main editor. The video series starts from nothing and ends with building a text-based RPG video game.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acrolinx result: video series which -> video series that

Comment thread docs/fsharp/index.md Outdated

* [Introduction to Programming with F# series on YouTube](https://www.youtube.com/watch?v=Teak30_pXHk&list=PLEoMzSkcN8oNiJ67Hd7oRGgD1d4YBxYGC)
* [Introduction to F# series on FSharpTV](https://fsharp.tv/courses/fsharp-programming-intro/)
[What's New in Visual Studio 2017 for F# For Developers](https://www.linkedin.com/learning/what-s-new-in-visual-studio-2017-for-f-sharp-for-developers) is a video course which shows some of the newer features for F# in Visual Studio 2017.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acrolinx result: course which -> course that

Comment thread docs/fsharp/index.md Outdated
* [F# Learning Resources on fsharp.org](http://fsharp.org/learn.html)
* [F# Snippets Website](http://www.fssnip.net)
* [F# Software Foundation](http://fsharp.org) No newline at end of file
To learn more and get involved, check out [fsharp.org](http://fsharp.org). It's 100% free to join, and the network of F# developers in the foundation is something you won't want to miss out on! No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acrolinx result: won't want -> don't want

@cartermp

cartermp commented Mar 5, 2018

Copy link
Copy Markdown
Contributor Author

@mairaw and @BillWagner any additional feedback?


### [Windows](#tab/windows)

If you're on Windows, you must [install Visual Studio with F# support](get-started-visual-studio.md#installing-f). This installs all the necessary components to write, compile, and execute F# code.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since installing VS is not the only option, I wouldn't use the word "must" here, even if you're not going to mention the other option.

Also, I find it weird that to use F# in one editor (VS Code), the easiest option is to first install another editor (VS). But I don't think you can fix that by changing what the docs say. 😄

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we complete F# support for FSI and Type Providers on .NET Core, Ionide must take a dependency on either Mono or .NET Framework and their build tools. This means that you need to manually install the .NET Framework (win7 or higher), F# Compiler SDK, MSBuild, and optionally set your PATHs appropriately if Ionide cannot detect them (reported before so it should be mentioned).

Having watched people struggle mightily with this in workshops, even with this doc, I've had them "just install VS" to make it easier and they were appreciative 😢. The removal here is based on this.

And actually, now that you've hit on this, this is not finished yet, since the .NET Core SDK is required for Ionide as well. I'll need to update that.

![](media/getting-started-vscode/vscode-proj-type.png)

This will select a template for a specific type of project. There are quite a few options here, such as an [FsLab](https://fslab.org) template for Data Science or [Suave](https://suave.io) template for Web Programming. This article uses the `classlib` template, so highlight that and hit **Enter**. You will then reach the following step:
This will select a template for a specific type of project. There are quite a few options here, such as an [FsLab](http://fslab.org) template for Data Science or [Suave](https://suave.io) template for Web Programming. This article uses the `classlib` template, so highlight that and hit **Enter**. You will then reach the following step:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the URL to HTTP here, when http://fslab.org redirects to https://fslab.org? I think it makes sense to use HTTPS URLs by default for sites where HTTPS works.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is fun. So I cloned this repo before @mairaw's PR to change all links to https, so it now registers as a change.

@BillWagner BillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great. I'm approving this to merge. I have a few suggestions that you can adopt as you see fit.

# Get Started with F# in Visual Studio Code

You can write F# in [Visual Studio Code](https://code.visualstudio.com) with the [Ionide plugin](https://marketplace.visualstudio.com/items?itemName=Ionide.Ionide-fsharp), to get a great cross-platform, lightweight IDE experience with IntelliSense and basic code refactorings. Visit [Ionide.io](https://ionide.io) to learn more about the plugin suite.
You can write F# in [Visual Studio Code](https://code.visualstudio.com) with the [Ionide plugin](https://marketplace.visualstudio.com/items?itemName=Ionide.Ionide-fsharp), to get a great cross-platform, lightweight IDE experience with IntelliSense and basic code refactorings. Visit [Ionide.io](http://ionide.io) to learn more about the plugin suite.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want http instead of https. however, ionide.io doesn't support https. @mairaw what do you recommend?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to keep only the links that worked with https but I guess I made a mistake here. I'd keep as http on this one.

## Prerequisites

F# 4.0 or higher must be installed on your machine to use Ionide.
You must have [git installed](https://git-scm.com/download) and available on your PATH to make use of project templates in Ionide. You can verify that it is installed correctly by typing `git` at a command prompt and pressing **Enter**.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit / suggestion: I usually say to type git --version to get version information as well.

```

Ionide automatically detects the compiler and tools, but if it doesn't for some reason (for example, the Visual F# Tools were installed to a different directory), you can manually add the containing folder (`...\Microsoft SDKs\F#\4.0`) to your PATH.
You must also install the [.NET Core SDK](https://www.microsoft.com/net/download/macos).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit / suggestion: you can omit '/macos' and it will auto detect the user's OS.

```

### Linux
You must also install the [.NET Core SDK](https://www.microsoft.com/net/download/linux).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as the mac installation.

```
If you're on Windows, you must [install Visual Studio with F# support](get-started-visual-studio.md#installing-f). This installs all the necessary components to write, compile, and execute F# code.

You must also install the [.NET Core SDK](https://www.microsoft.com/net/download/windows/).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, the page detects the OS from the browser.

Comment thread docs/fsharp/index.md
## Learning F# #

Although Microsoft is the primary developer of the F# language and its tooling, F# is also backed by an independent foundation, the F# Software Foundation (FSSF).
[Tour of F#](tour.md) gives an overview of major language features with lots of code samples. This is recommended if you are new to F# and want to get a feel for how the language works.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the tour also be useful for new developers? If not, is there a new programmers introduction to F#?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, but most of the data I've seen about FP indicates that it's not something new programmers get into. Not until it's taught in beginner courses in university, at least.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I think the important point is to identify the audience so they can self-select the right locationn.

Comment thread docs/fsharp/index.md Outdated
* [Functions as First-Class Values](introduction-to-functional-programming/functions-as-first-class-values.md)<!--[Introduction to Functional Programming](introduction-to-functional-programming/index.md)-->
* [Language Reference](language-reference/index.md)
* [F# Core Library Reference](https://msdn.microsoft.com/visualfsharpdocs/conceptual/fsharp-core-library-reference)
[F# Programming Wikibook](https://en.wikibooks.org/wiki/F_Sharp_Programming) is a wikibook about learning F#. It is also a product of the F# community.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who would be the target audience for the wikibook? That would be important for this audience.

Reading on, this comment applies to all the resources you mention: If you know the target audience, that would be useful to know.

Comment thread docs/fsharp/index.md Outdated
* [F# Learning Resources on fsharp.org](http://fsharp.org/learn.html)
* [F# Snippets Website](http://www.fssnip.net)
* [F# Software Foundation](http://fsharp.org) No newline at end of file
To learn more and get involved, check out [fsharp.org](http://fsharp.org). It's 100% free to join, and the network of F# developers in the foundation is something you don't want to miss out on! No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this, and move the link to the text "..., the F# Software Foundation (FSSF)"

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but I think you should address the comments that Bill and I left before merging.

### [Linux](#tab/linux)

On macOS, Ionide uses [Mono](https://www.mono-project.com). The easiest way to install Mono on macOS is via Homebrew. Simply type the following into your terminal:
On Linux, Ionide also uses [Mono](http://www.mono-project.com). If you're on Debian or Ubuntu, you can use the following:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove extra spaces between sentences (it happens frequently)

also, for this link the https link works for me

the following what? commands?

2. The correct directory structure for adding packages via [`Paket`](https://fsprojects.github.io/Paket/).
3. A cross-platform build script with [`FAKE`](https://fake.build/).
2. The correct directory structure for adding packages via [`Paket`](http://fsprojects.github.io/Paket/).
3. A cross-platform build script with [`FAKE`](http://fsharp.github.io/FAKE/).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd bring the link that I fixed back

1. The F# project itself, underneath the `ClassLibraryDemo` folder.
2. The correct directory structure for adding packages via [`Paket`](https://fsprojects.github.io/Paket/).
3. A cross-platform build script with [`FAKE`](https://fake.build/).
2. The correct directory structure for adding packages via [`Paket`](http://fsprojects.github.io/Paket/).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https link

Comment thread docs/fsharp/index.md Outdated
[Tour of F#](tour.md) gives an overview of major language features with lots of code samples. This is recommended if you are new to F# and want to get a feel for how the language works.

The mission of the F# Software Foundation is to promote, protect, and advance the F# programming language, and to support and facilitate the growth of a diverse and international community of F# programmers.
[Get started with F# in Visual Studio](get-started/get-started-visual-studio.md) if you're on Windows and want the full Visual Studio IDE experience.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define what IDE is on first usage

Comment thread docs/fsharp/index.md Outdated

[Get Started with F# in Visual Studio Code](get-started/get-started-vscode.md) if you want a lightweight, cross-platform, and feature-packed IDE experience.

[Get started with F# with the .NET Core CLI](get-started/get-started-command-line.md) if you just want a great set of command-line tools.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a bit marketing to me.

@cartermp
cartermp merged commit ff9731b into dotnet:master Mar 14, 2018
@cartermp

Copy link
Copy Markdown
Contributor Author

And now, to fix up the VSCode article and tour and numerous other backlog issues 😄

luyajun0205 pushed a commit to OPS-E2E-Prod/docs that referenced this pull request Mar 19, 2018
* Fixes and improvements to Semantic analysis Get started (dotnet#4575)

* Order the definitions to match the order of terms (dotnet#4576)

The introductory sentence could be read as implying
definitions that contradict the body of the article.

* Fix invalid Windows file system paths (dotnet#4559)

* Fix invalid Windows file system paths

* Add escape characters

* Fixing capitalization of Visual Basic (dotnet#4578)

Changed "Visual basic" to "Visual Basic" for the description of the Get Visual Basic link.

* Fixed broken links in interop docs (dotnet#4573)

* Fixed broken links in interop docs

* Updated additional links

* Removed 'en-us' from URLs

* Fixing broken link to MVA course (dotnet#4580)

Visual Basic Fundamentals for Absolute Beginners link was directing to a list of courses, not really related to VB.  I've updated the link directly to the course.  I did check to see if the course was in other languages before putting in the en-US link - looks like it's available only in English.

* Minor refactoring (dotnet#4582)

Change "new ValidationResult(true, null)" to "ValidationResult.ValidResult", since it looks a little cleaner and the property was explicitly designed for that use.

* Fixed link (dotnet#4583)

* Update "How to: Modify string" (dotnet#4519)

* article and code moved

* interim checkin

Switching tasks.

* checkin to run test build

I want to see if I can use local functions in C# interactive.

* finish samples and new draft

Ready for my first review.

* fix build errors

* proofread

* update per feedback.

* respond to feedback.

* additional feedback.

* respond to feedback.

* Fix escape characters in HttpListener Remarks section (dotnet#4495)

* Minor refactoring (dotnet#4584)

Change "New ValidationResult(True, Nothing)" to "ValidationResult.ValidResult", since it looks a little cleaner and the property was explicitly designed for that use.

* fix title (dotnet#4590)

* fix broken links (dotnet#4588)

* Add the closing token for an XML include (dotnet#4593)

Without this, the rest of the file renders incorrectly.

* Correct description of ROOT parameter (dotnet#4595)

* Update tuples.md "Interoperation with C# Tuples" content (dotnet#4581)

*  Removed an excessive "and" 
*  Removed some text that didn't seem overly clear.

* Replaced link to UserVoice (dotnet#4594)

* Removed link to UserVoice

* Changed URL target

* Fix typo (dotnet#4599)

* Experiment: CodeOwners (dotnet#4597)

* Experiment: CodeOwners

Trying an experiment to see how we might use use the CODEOWNERS file to get reviews routed to the right person.

* Added several sections

* Update CODEOWNERS

* Fixing anchor link to the "private protected access modifier" section (dotnet#4601)

* fixes to the CODEOWNERS (dotnet#4602)

* fixes to the CODEOWNERS

The changes here:
1. The '@' is needed on each user name.
1. The C# Snippets was missing the 'csharp' directory component.
1. Order is important.

* Add F# guide.

* modify-string-contents.md: added interactive note (dotnet#4607)

* Fix markdown table (dotnet#4603)

Fix usage of `|` in markdown (use `&#124;` instead)

* Update infrastructure-persistence-layer-implemenation-entity-framework-core.md (dotnet#4610)

Update link to the new address to avoid an extra 301 redirect.

* csharp-interactive-note.md: style update (dotnet#4606)

* parallel-diagnostic-tools.md: removed Visual Studio version (dotnet#4608)

* adding missing language identifiers (dotnet#4611)

* adding missing language identifiers (dotnet#4612)

* adding missing language identifiers (dotnet#4613)

* adding missing language identifiers (dotnet#4614)

* adding missing language identifiers (dotnet#4615)

* adding missing language identifiers (dotnet#4616)

* adding missing language identifiers (dotnet#4617)

* adding missing language identifiers (dotnet#4618)

* adding missing language identifiers (dotnet#4619)

* adding missing language identifiers (dotnet#4620)

* adding missing language identifiers (dotnet#4621)

* adding missing language identifiers (dotnet#4622)

* adding missing language identifiers (dotnet#4623)

* Fixed some attribute names (dotnet#4629)

.NET puts the "Attribute" suffix in all its attribute *classes*, but not in the actual attribute.

* Fix "whitespace" words - docs/standard (dotnet#4605)

* base-types

* fixes by pr rpetrusha

* System.Reflection docs for ProcessorArchitecture is misleading (dotnet#4539)

* clarify the difference betwen IA64 and AMD64

* Update ProcessorArchitecture.xml

* Changed 'integer' to 'integral value' for consistency (dotnet#4586)

* 👓 sweep docset for areas where `in` wasn't mentioned but should be (dotnet#4534)

* sweep docset for areas where `in` wasn't mentioned but should be

* respond to first round of feedback

* create in-modifer article

Also, update samples and snippets and make corresponding changs to 'ref' and 'out' article.

* fix build errors

* fix one more build error

* wording change based on feedback.

* respond to edits

* commit changes from that unsaved window

Yeah, I did that. Didn't save before committing.

* added missing options (dotnet#3390)

* Add warning regarding server host configuration (dotnet#4634)

* Fix some xrefs (dotnet#4624)

* Fix some xrefs

* Fixed typo

* Change hybrid xref links to normal xrefs

* Remove redundant text with bad link

* Update compiler-api-model.md (dotnet#4636)

fix small typos

* Corrected description of verbatim attribute usage (dotnet#4635)

* removed sentence about migrating content (dotnet#4532)

* removed sentence about migrating content

* removed preview

* Update the F# Guide page and some ms.date links (dotnet#4521)

* Update to F# docs round 1

* yup

* fix

* feedback

* Fix link

* feedback

* Updates

* Updates

* Updates

* Make comments betteR

* Feedback

* Feedback

* fixes

* Improvements to Creating a Type Provider (dotnet#4592)

* Improvements to Creating a Type Provider

* Fixed assembly attribute

* Revision of DateTime.Parse overloads (dotnet#4455)

* Revision of DateTime.Parse

* Additional modifications

* Some further revisions

* Additional revisions

* Corrected bad XML tags

* Moved examples

* Additional revisions and .zip files

* Added accidentally deleted file

* Addressed review comments

* keywords/string.md: link verbatim identifier page (dotnet#4639)

* C13890: Show code for link in target versions (dotnet#4641)

Hello, @BillWagner, 

Localization team has reported source content issue that causes localized version to have broken format compared to en-us version.  

Please, help to check my proposed file change into the article and help to merge if you agree with fix. If not, please, let me know either if you would like me to fix it in another way within this PR, if you prefer to fix it in another PR or if I should close this PR as by-design. In case of using another PR, please, let me know of your PR number, so we can confirm and close this PR. 

Many thanks in advance.

* C13891: Show code for link in target versions (dotnet#4642)

* Fix incorrect en dashes (dotnet#4644)

* replace BNF grammar with ANTL grammar (dotnet#4643)

* replace BNF grammar with ANTL grammar

The BNF grammar rendering was quite messy. Antlr provides a much more clear rendering on the current engine.

* fix typo and update metadata

* Added output comment to verbatim string code snippet (dotnet#4646)

* added missing entry (dotnet#4648)

* simplify template (dotnet#4645)

* simplify template

* feedback

* Fixed broken links to archived interop topics (dotnet#4647)

* Changed HSB to HSL color model (dotnet#4652)

* Changed HSB to HSL color model

* Addressed review comments

* Fix connect bug DevDiv # 93543 (dotnet#4653)

* fix broken link (dotnet#4655)

* Add displayProperty attribute to address customer complaint in SqlParameter.Value docs (dotnet#4660)

* Fix connect bug DevDiv # 93543

* Add clarifications to links to address DevDiv Connect Bug # 104024

* add one more displayproperty

* including the template in the treeview (dotnet#4662)

Adding reference the hierarchical template in the treeview

* Replace IIF with IF (dotnet#4665)

* Added GetHashCode() implementation to ValueObject (dotnet#4185)

This will be very helpful to readers. Picked it up from eShopOnContainers repo.

* Provided correct enum members, method overloads (dotnet#4484)

* Provided correct enum members, method overloads

* Incorporated review comments, corrected other errors

* Fixed 2 broken links

* Fixed two additional links

* Added exception information to SingleOrDefault (dotnet#4650)

* Added information on string length >= desired string length (dotnet#4651)

* Added information on string length >= desire string length

* fixed broken link

* Incorporated comments from @svick

* TLS best practices (dotnet#4658)

* IIF to IF on Tuples page (dotnet#4669)

* fix: derrived --> derived typo (dotnet#4673)

* Modified contributors guide to reflect contributors' project (dotnet#4666)

* Add link to github issue to TLS doc (dotnet#4676)

* fix link (dotnet#4672)

* fix typo (dotnet#4678)

* Remove extra backslash (dotnet#4680)

* Fix markdown link (dotnet#4679)

* Fix markdown link

* feedback

* update signalr info for 2.1 preview (dotnet#4681)

* Fix typo (dotnet#4683)

* fixed typo

* fix typo

* add PDF to preview serverless e-book (dotnet#4685)

* Removed spaces in code (dotnet#4671)

* Fixed typo in --x operator description (dotnet#4691)

* Add syntax highlighting to inline code in stackalloc (dotnet#4690)

Just noticed on docs.microsoft.com that these code blocks don't have syntax highlighting, which does not adhere to the style guide

* Add UWP as platform that supports .NET Standard (dotnet#3813)

* Add UWP as platform that supports .NET Standard

https://blogs.msdn.microsoft.com/dotnet/2017/10/10/announcing-uwp-support-for-net-standard-2-0/

* Add platforms; remove versions; add link

Instead of listing the same platforms that are listed on https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support and having to maintain both lists as new versions are released, just mention the platforms here and link to the existing table with versions.

Closes dotnet#3814

* feedback

* < and > wrong (dotnet#4664)

* < and > wrong

< and > were not in code

* Updated xref

Updated xref to correct signature

* removing tickmarks and overloads

* some other minor fixes

* Update net-standard.md (dotnet#4694)

* Correct time complexity of List<T>.InsertRange (dotnet#4693)

*  Operator new doesn't create structs on the stack  (dotnet#4667)

* Operator new doesn't create structs on the stack

* Small improvements to operator new

* Structs can contain resources too

* Mention garbage collector

* Clarified when value types are destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants